Swift: Adopt the smaller macOS host libraries - #22452
Open
henrymercer wants to merge 4 commits into
Open
Conversation
Point at the staging artifact built with the x86_64-only thinning from semmle-code. Must be reverted before merging. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03df685d-b0f4-4920-8c7c-8e70c6c868bf
The semmle-code change now thins only `usr/lib/swift/host`, so test that artifact rather than the earlier one which also thinned the per-target libraries.
henrymercer
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The change updates a large binary/toolchain resource via Git LFS, and the correctness of the new archive’s contents (beyond the pointer metadata) can’t be validated from the diff alone.
Review tier: Lite
Findings: None
What changed in this PR
Updates the Swift macOS resource archive used by the Swift toolchain integration to a smaller, host-thinned variant, reducing the checked-in Git LFS artifact size while keeping the Swift version pinned at 6.3.3.
Changes:
- Replaces
swift/third_party/resources/resource-dir-macos.zip(Git LFS pointer) with a new object ID and smaller recorded size.
| File | Description |
|---|---|
| swift/third_party/resources/resource-dir-macos.zip | Updates the Git LFS pointer to the new, smaller macOS Swift resource archive. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the macOS Swift resource archive with the host-only thinned version and remove the staging override. This reduces the archive from 548 MB to 433 MB.
Only the host libraries are thinned to x64. Target SDK/runtime libraries and module metadata are unchanged, and Swift remains at 6.3.3.